Skip to content

Commit

Permalink
Merge pull request #4770 from kobotoolbox/transparent-data-column-bug
Browse files Browse the repository at this point in the history
Fix styling for frozen columns in data table
  • Loading branch information
magicznyleszek committed Jan 16, 2024
2 parents 4e1c442 + 4e56206 commit 4a9d5ed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion jsapp/js/components/submissions/table.es6
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,9 @@ export class DataTable extends React.Component {
col.className = col.className
? `is-frozen is-last-frozen ${col.className}`
: 'is-frozen is-last-frozen';
col.headerClassName = 'is-frozen is-last-frozen';
col.headerClassName = col.headerClassName
? `is-frozen is-last-frozen ${col.headerClassName}`
: 'is-frozen is-last-frozen';
}
});

Expand Down
5 changes: 3 additions & 2 deletions jsapp/js/components/submissions/table.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@use '~kobo-common/src/styles/colors';
@use 'scss/z-indexes';
@use 'js/components/common/checkbox';
@use 'sass:color';

// These are custom styles for Table View table.

Expand Down Expand Up @@ -471,11 +472,11 @@ $s-data-table-font: 13px;
}

.rt-th.is-sorted {
background-color: rgba(colors.$kobo-light-teal, 0.5);
background-color: color.adjust(colors.$kobo-light-teal, $lightness: 4%);
}

.rt-td.is-sorted {
background-color: rgba(colors.$kobo-light-teal, 0.2);
background-color: color.adjust(colors.$kobo-light-teal, $lightness: 8%);
}

// NOTE: submissions actions column is always frozen as first column
Expand Down

0 comments on commit 4a9d5ed

Please sign in to comment.