prevent non-string row types from breaking save

rows with row['type'] = {'x':'y'} is deprecated
kobotoolbox · Oct 21, 2016 · ded418c · ded418c
1 parent b79ffa0
commit ded418c
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/kpi/utils/asset_content_analyzer.py b/kpi/utils/asset_content_analyzer.py
@@ -27,15 +27,13 @@ def get_summary(self):
             return {}
 
         for row in self.survey:
-            # pyxform's csv_to_dict() returns an OrderedDict, so we have to be
-            # more tolerant than `type(row) == dict`
             if isinstance(row, dict):
                 _type = row.get('type')
                 _label = row.get('label')
                 if _type in GEO_TYPES:
                     geo = True
 
-                if not _type or _type.startswith('end'):
+                if not _type or isinstance(_type, dict) or _type.startswith('end'):
                     summary_errors.append(row)
                     continue
                 if _type in META_TYPES: