[Public Collections] Feature polishing feedback

[magicznyleszek]

Description

• disallow making empty collections public (hint: add children check to assetUtils.isAssetPublicReady function)

• reset filters button for table is not needed

• move number of children (out from next to name) to a separate column

• the number of children is sometimes wrong The number in the grey circle (child assets) is wrong, at least sometimes: tinokreutzer's 'Sample Library Blocks' has 60 assets, but in the table's grey circle it says '1'. This is also in the JSON for the search result. Whereas the children count of the asset itself is reliably 60.

• don't display all columns for My Library The columns in the Public Collections view are not needed in the main library view since questions and blocks can't have an Organization, Primary Sector, or Country attached to them. This means these rows are almost always empty; only public collections or templates would have this information, but it's not a good use of space to show this in the main library view

• similarly to above Sector, Country, and Organization are not needed in the single question block view since there is no way to specify this information

• Search in library view is not applied to questions and blocks Search terms are only added to the Collections query, not the asset_type:question OR asset_type:block

• "Back" button is misaligned on asset page (Chrome?)

• searching for a question inside a collection - is it possible from My Library?

• fix unnecessary search calls (jnm edit: detailed at [Public Collections] Don't make unnecessary callls before visiting Library route #2808?)

• fix filtering: It works to filter for "Central African Republic" but when I filter by organization (UNDP CAR) or Primary Sector (Economic/Social development) I get 0 results. Expected: I should get the same result each time moved to [Public Collections] Allow multiple filters to be selected in AssetsTable component #2835

• Cloning an asset from a subscribed Collection causes 400/500 errors 🐛 moved to [Public Collections] Cloning asset from a subscribed Public Collection is not possible #2836

• Collection content is displaying only 10 items 🐛 moved to [Public Collections] Single collection page only shows first page (10) of children with no way of loading more #2834

• You can't add subscribed collection items in Form Builder 🐛 moved to Public Collections: formbuilder library sidebar does not display any assets for subscribed collections #2832

• Fix search 🐛 moved to Search term without field should query asset.name #2814

[jnm]

@magicznyleszek, this is ready to close, right?