Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Public Collections] Single collection page only shows first page (10) of children with no way of loading more #2834

Closed
magicznyleszek opened this issue Oct 12, 2020 · 2 comments
Assignees
Labels
bug Things broken and not working as expected has PR UI & UX User interface problems and improvements

Comments

@magicznyleszek
Copy link
Member

magicznyleszek commented Oct 12, 2020

Description

So the assumption was that .children will contain all the children. It was a bad assumption as .children have a standardized count, next, previous and results (the de facto list of children).

Expected behavior

Single collection page uses component from assetsTable.es6 which has a built-in capability of displaing pagination and a change page callback.

There are two ways of handling this:

  1. Easier - Use AssetsTable,
    provide proper pagination properties and on add a functionality to assetRoute.es6 that uses the callback to load next or previous page of child assets.
    AssetsTable already has pagination properties and expects its logic to be passed on instantiation, collectionAssetTable should be the one to pass the logic to it
    It would be nice to increase the default limit from 10 to a bigger number. (I've changed it already to 100)
  2. Harder - Drop pagination from AssetsTable and instead use an infinite scroll solution that will load next pages of results. This change will require to update all the places that uses AssetsTable. It was agreed that we don't want infinite scroll :)
@magicznyleszek magicznyleszek added bug Things broken and not working as expected UI & UX User interface problems and improvements labels Oct 12, 2020
@magicznyleszek
Copy link
Member Author

Note to a person fixing that: assetRoute.es6 is being used to display all asset types. I think that it would be best to create a wrapper component for collections. This component should be used instead of AssetsTable, and contain the pagination functionality and rendering just the AssetsTable.

@jnm
Copy link
Member

jnm commented Apr 1, 2021

Fixed by #2882

@jnm jnm closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things broken and not working as expected has PR UI & UX User interface problems and improvements
Projects
None yet
Development

No branches or pull requests

3 participants