Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete entire group functionality #3132

Closed
magicznyleszek opened this issue Apr 14, 2021 · 3 comments · Fixed by #3146 or #3288
Closed

Delete entire group functionality #3132

magicznyleszek opened this issue Apr 14, 2021 · 3 comments · Fixed by #3146 or #3288
Labels
enhancement Ideas, improvements and features formbuilder Mainly changes to our coffeescript part of KPI Front end

Comments

@magicznyleszek
Copy link
Member

Description

We need a way for users to delete the whole group with all inside. So when clicking the delete (trash bin) button we get something like that:

Screenshot 2021-04-14 at 21 52 05

Additional details

Needed for #3082

@magicznyleszek magicznyleszek added enhancement Ideas, improvements and features formbuilder Mainly changes to our coffeescript part of KPI Front end labels Apr 14, 2021
@Ig-Rebollo
Copy link

Ig-Rebollo commented Apr 16, 2021

@magicznyleszek @tinok Two parts to this:

  1. The best way to do this would be to simply have a button to split the group, different from the delete button. So, instead of just settings and delete, you would have settings, delete, and split group.
    image
    The split group icon could be done with a variation of the group icon on the navigation bar
    image
    Unfortunately with the current layout, an additional icon would make the space increase in height, which would look strange and make the form longer, so it is better not to do this. Ideally, we will want to do it this way only when we redesign the form builder, as I plan to lay out the question action icons horizontally instead of vertically. For the time being, it is better to go with the modal approach.

  2. For the current modal, I feel we either don't need the 'cancel' or the 'X' on the top right corner. Having both is a bit redundant. Also I would try to be clearer in each button. Instead of 'split' and 'delete' might be better to have 'ungroup questions' and 'delete everything'
    image

@magicznyleszek
Copy link
Member Author

Using modal would also be preferable in current Form Builder, because users are accustomed to having the split functionality under the "trash bin" icon.

I am working on it already :)

@Ig-Rebollo
Copy link

Great! Thanks @magicznyleszek here is the icon in svg
ungroup-icon.svg.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas, improvements and features formbuilder Mainly changes to our coffeescript part of KPI Front end
Projects
None yet
2 participants