Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow ups on #3648 #3784

Open
jnm opened this issue Apr 27, 2022 · 0 comments
Open

Follow ups on #3648 #3784

jnm opened this issue Apr 27, 2022 · 0 comments
Assignees

Comments

@jnm
Copy link
Member

jnm commented Apr 27, 2022

PR #3648 adds some code to MockDeplyomentBackend that never gets reached by our unit tests. We should add a new test so that this code does get executed during testing.

_() isn't imported. I'll fix it, but I'll also open a new issue about adding test code that reaches these lines.
Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/Unused.20test.20code/near/104338

Originally posted by @jnm in #3648 (comment)

Additionally, we probably shouldn't use Kobocat* stuff in the mock backend. I think it's an easy fix in this case: can these these particular exceptions be renamed, given that seems generic and not tied specifically to Kobocat? [This has been addressed in #4829]

Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/Unused.20test.20code/near/104352

jnm added a commit that referenced this issue Jan 31, 2024
jnm added a commit that referenced this issue Jan 31, 2024
jnm added a commit that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants