Fix assets submission count missing with 'view_submissions' of project views #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and rename 'change_metadata' to 'change_metadata_asset' for consistency with DRF
noliveleger
force-pushed
the
fix-submission-counts-with-view-submissions
branch
from
cdcc23b
to
3bf29be
Compare
noliveleger
force-pushed
the
fix-submission-counts-with-view-submissions
branch
from
46eeff7
to
dc61565
Compare
Add NLP to service usage API
jnm
requested changes
Jan 23, 2023
There was a problem hiding this comment.
@noliveleger good to go after adding the test we discussed!
…com:kobotoolbox/kpi into fix-submission-counts-with-view-submissions
…e' and 'settings'
noliveleger
force-pushed
the
fix-submission-counts-with-view-submissions
branch
from
ff12597
to
3a3f134
Compare
jnm
reviewed
Jan 24, 2023
kpi/tests/api/v2/test_api_assets.py
Outdated
Comment on lines
577
to
582
| assert self._sorted_dict(asset_data['summary']) == self._sorted_dict( | ||
| asset_data['summary'] | ||
| ) | ||
| assert self._sorted_dict(asset_data['content']) == self._sorted_dict( | ||
| asset_data['content'] | ||
| ) |
There was a problem hiding this comment.
@noliveleger these are like assert x == x are they not? 🧐 Reformatted:
assert self._sorted_dict(asset_data['summary'])
== self._sorted_dict(asset_data['summary'])
assert self._sorted_dict(asset_data['content'])
== self._sorted_dict(asset_data['content'])There was a problem hiding this comment.
Oops :-P Indeed. Not what I wanted to do.
That's how you make tests pass no matter what :-P
jnm
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Returns the correct number instead of 0
Related issue
Close #4194
Additional info
asset.has_perm(user, permission)returnsTrueifuserbelongs to a project view that haspermissionselected forasset. Previous behaviour wasFalse.change_metadatapermission has been renamechange_metadata_assetto be consistent with other permissions.