Add archive and delete button to project settings #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jnm
requested changes
Dec 7, 2018
| <bem.FormModal__item m='inline'> | ||
| <button | ||
| type='button' | ||
| className='mdl-button mdl-button--colored mdl-button--danger mdl-button--raised' |
There was a problem hiding this comment.
(Un)archiving isn't really dangerous the way deleting is. Could you change this button to be a different color?
There was a problem hiding this comment.
I've changed the archive button to orange (because it is in a way more serious than normal button), and unarchive to blue (to match some other place that has unarchive button).
jnm
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second part of kobocat template changes (see kobotoolbox/kobocat-template#92):
New buttons are added on the end of scrollable area (after iframe):
Related issues
Part of kobotoolbox/kobocat#488