Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra whitespace in New Project modal #2121

Merged
merged 6 commits into from
Dec 11, 2018
Merged

Conversation

magicznyleszek
Copy link
Member

Description

Simple media query added

Related issues

Fixes #2112

Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, I'm sorry, but this made me giggle like a little kid:
image
grown-up talk: something's not right when choosing "Use a template." Tested in Chrome and Firefox.

@magicznyleszek
Copy link
Member Author

magicznyleszek commented Dec 11, 2018

@jnm I fixed two things: templates list not being 100% width and the funny thing. The funny thing is all radios and checkboxes appearing wrong, because of my webpack config fix from today - I added a commit that brings back autoprefixer plugin there (it is in the postcss.config.js, and the HACK empty array plugins was disabling it)

Edit: I also added a comment to the webpack config file about why we did this for future generations ;-)

@jnm jnm merged commit 18d0f3b into master Dec 11, 2018
@jnm jnm deleted the 2112-fix-extra-whitespace branch December 11, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants