Define shadow UserObjectPermission; fixes #2148 #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes django-guardian dependency
jnm
commented
Jan 3, 2019
| @@ -85,7 +84,7 @@ pytest==3.0.3 # via pytest-django | |||
| python-dateutil==2.6.0 | |||
| python-digest==1.7 | |||
| pytz==2016.4 | |||
| pyxform==0.11.5 | |||
| pyxform==0.12.0 | |||
There was a problem hiding this comment.
make pip_compile made this change. Seemed fine to me since requirements.txt and dev_requirements.txt already had it.
...and fix a troublesome `__unicode__()` method copied from django-guardian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes django-guardian dependency (and its pesky warning!)
Edit: this doesn't work. Or, more accurately, it works only in threads where the shadow models have not been defined yet.(Fixed!)