Update and fix babel building #2471
Conversation
# Conflicts: # package-lock.json
Resolved Conflicts: jsapp/js/components/RESTServices/RESTServicesForm.es6 jsapp/js/components/permissions/userAssetPermsEditor.es6 jsapp/js/components/textBox.es6 package-lock.json
There was a problem hiding this comment.
LGTM 👍
@magicznyleszek, For my information (and my curiosity), why sometimes you choose a named export over a default export?
e.g. import {keymap} from './keymap';
I would have thought keymap should be a default export.
|
@noliveleger I don't have an opinion on this, I just do what works :-P (:-1: me). After updating one of the dependencies build process started to complain about unnamed default exports, so I changed them. But then some other dependency also got updated and I think it doesn't complain anymore, as I was able to change keymap to unnamed default export 🤷♀ I read about some reasoning as to why it is potentially dangerous to use unnamed default exports, but don't remember what it was exactly - something about overwriting variables… |
Description
New babel isn't so forgiving in exports, so it needed quite a few changes.
Related issues
Fixes #2012