Use XlsxWriter instead of xlwt in to_xls_io() #2592
Conversation
jnm
changed the title
XLSX is now used instead of XLS when deploying forms to KoBoCAT and downloading forms as XLSForm. Fixes #2591.
jnm
force-pushed
the
2591-use-xlsxwriter-in-to_xls_io
branch
from
cb68444
to
5dcdce3
Compare
| @@ -72,6 +72,7 @@ unicodecsv | |||
| uWSGI | |||
| xlrd | |||
| xlwt | |||
There was a problem hiding this comment.
Would we like to replace xlwt everywhere?
There was a problem hiding this comment.
Maybe. I left xlwt in sync_kobocat_xforms because I thought that maybe xlwt is faster than XlsxWriter, and that XLS files are generally smaller than XLSX—but I haven't tested my assumptions.
Probably what would be better is to convert directly from CSV to KPI asset JSON instead of using XLS(X) at all:
kpi/kpi/management/commands/sync_kobocat_xforms.py
Lines 169 to 175 in 5dcdce3
There was a problem hiding this comment.
Indeed.
Let's keep this for later then.
| self.get_object().uid, | ||
| request.accepted_renderer.format | ||
| ) | ||
| ] = 'attachment; filename={}'.format(filename) |
There was a problem hiding this comment.
I agree that it'd be better, but I see myself having to backport this to Python 2 😐
There was a problem hiding this comment.
As the above comment. Let's keep the change for later (after python2 support drop).
PS: I won't repeat this 4 times :P
| filename = '.'.join((self.get_object().uid, 'xlsx')) | ||
| response[ | ||
| 'Content-Disposition' | ||
| ] = 'attachment; filename={}'.format(filename) |
There was a problem hiding this comment.
I agree that it'd be better, but I see myself having to backport this to Python 2 😐
| filename = '.'.join( | ||
| (self.get_object().uid, request.accepted_renderer.format) | ||
| ) |
There was a problem hiding this comment.
I agree that it'd be better, but I see myself having to backport this to Python 2 😐
| if isinstance(request.accepted_renderer, XlsRenderer): | ||
| # `accepted_renderer.format` is 'xls' here for historical | ||
| # reasons, but what we actually serve now is xlsx (Excel 2007+) | ||
| filename = '.'.join((self.get_object().uid, 'xlsx')) |
There was a problem hiding this comment.
I agree that it'd be better, but I see myself having to backport this to Python 2 😐
XLSX is now used instead of XLS when deploying forms to KoBoCAT and downloading forms as XLSForm. Fixes #2591.