Send translation settings with saved rows to question library #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicznyleszek
requested changes
Jul 30, 2020
|
@duvld also feel free to merge this PR when you fix these few minor things :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms with translations could not transfer their translation settings when saving a row to library. This was due to
unnullifyTranslationsnot being called when saving a single row to the question library.This PR fixes this issue by sending the entire survey to
unnullifyTranslationsthen fishing out the row being saved and sending said row and its translation to the question library. This could be potentially heavy if there is a large form - if so adding a single row version ofunnullifyTranslationsmay be needed.Description
Include translations when saving a question from the form builder to the question library
Related issues
Fixes #2731