Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom export format options fix #3108

Merged
merged 4 commits into from Mar 24, 2021
Merged

Custom export format options fix #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8398dc7
disable (un)select all rows buttons when toggle switch is not enabled
magicznyleszek Mar 24, 2021
d8b40d3
fix label text
magicznyleszek Mar 24, 2021
c40d2be
disable export button when zero rows selected
magicznyleszek Mar 24, 2021
e65dc89
rewrite format options list to work with single named language and un…
magicznyleszek Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
54 changes: 34 additions & 20 deletions jsapp/js/components/projectDownloads/projectExportsCreator.es6
View file
Open in desktop
Expand Up @@ -148,26 +148,33 @@ export default class ProjectExportsCreator extends React.Component {
}

getExportFormatOptions() {
if (this.props.asset.summary?.languages.length >= 2) {
const options = [];
// all defined languages should go first
// and they replace `_default` option
const options = [];

// Step 1: add all defined languages as options (both named and unnamed)
if (this.props.asset.summary?.languages.length >= 1) {
this.props.asset.summary.languages.forEach((language, index) => {
options.push({
value: language,
label: language,
langIndex: index, // needed for later
});
// unnamed language gives the `_default` option
if (language === null) {
options.push(EXPORT_FORMATS._default);
} else {
options.push({
value: language,
label: language,
langIndex: index, // needed for later
});
}
});
options.push(EXPORT_FORMATS._xml);
return options;
} else {
return [
// `_default` should be first
EXPORT_FORMATS._default,
EXPORT_FORMATS._xml,
];
}

// Step 2: if for some reason nothing was added yet, add `_default`
if (options.length === 0) {
options.push(EXPORT_FORMATS._default);
}

// Step 3: `_xml` is always available and always last
options.push(EXPORT_FORMATS._xml);

return options;
}

/**
Expand Down Expand Up @@ -586,16 +593,22 @@ export default class ProjectExportsCreator extends React.Component {
this,
'isCustomSelectionEnabled'
)}
label={t('Select which questions to be exported')}
label={t('Select questions to be exported')}
/>

<bem.ProjectDownloads__textButton onClick={this.selectAllRows}>
<bem.ProjectDownloads__textButton
disabled={!this.state.isCustomSelectionEnabled}
onClick={this.selectAllRows}
>
{t('Select all')}
</bem.ProjectDownloads__textButton>

<span className='project-downloads__vr'/>

<bem.ProjectDownloads__textButton onClick={this.clearSelectedRows}>
<bem.ProjectDownloads__textButton
disabled={!this.state.isCustomSelectionEnabled}
onClick={this.clearSelectedRows}
>
{t('Deselect all')}
</bem.ProjectDownloads__textButton>
</bem.ProjectDownloads__columnRow>
Expand Down Expand Up @@ -749,6 +762,7 @@ export default class ProjectExportsCreator extends React.Component {
m='blue'
type='submit'
onClick={this.onSubmit}
disabled={this.state.selectedRows.size === 0}
>
{t('Export')}
</bem.KoboButton>
Expand Down
5 changes: 5 additions & 0 deletions jsapp/scss/components/_kobo.project-downloads.scss
View file
Open in desktop
Expand Up @@ -102,6 +102,11 @@
transform: translateY(1px);
}

&[disabled] {
pointer-events: none;
opacity: 0.5;
}

.k-icon {
vertical-align: middle;
margin-left: 3px;
Expand Down