[Feature] Column filtering for basic case management #3117
Conversation
Conflicts: jsapp/js/actions.es6 jsapp/js/components/modalForms/connectProjects.es6 and some clean up
also added missing common components
Conflicts: jsapp/js/components/modalForms/connectProjects.es6
Clean up with PR Changes of #3057 in mind Conflicts: jsapp/js/actions.es6 jsapp/js/components/formSubScreens.es6 jsapp/js/components/modalForms/connectProjects.es6 jsapp/scss/components/_kobo.connect-projects.scss jsapp/scss/main.scss
| } | ||
|
|
||
| componentWillUnmount() { | ||
| this.unlisteners.forEach((clb) => {clb();}); |
There was a problem hiding this comment.
Maybe rather this?
this.unlisteners.forEach(clb => clb());There was a problem hiding this comment.
Actually everywhere else does it like this, maybe a question for @magicznyleszek :D
There was a problem hiding this comment.
Yeah let's do it like that 👍 I have personal issue with that due to too much coffeescripting :P but it's not a logical argument :)
- use const/let properly - use safer/consistent object access - alertify error handling for all requests
- remove unused imports - fix css class mismatch - don't mutate state object directly for fieldsErrors
in case of future use
|
Sorry for the delay @duvld and @joshuaberetta Here are some mockups on how to implement these suggestions.
As you can see I included a counter to give users confirmation of when the questions have been actually shared (if they click on the 'share' button without selecting any questions, maybe a notification saying 'no questions have been selected' could appear. The 'loading' could be part of the button itself
Note I also changed the wording for the description text on top of the table. I liked @joshuaberetta option better. Let me know what you think! |
…nent (other occurrences)
Merge and test #3057 first!
Description
Extends base UI for exporting/importing data across connected projects with column (question) selection
Related issues
Column filtering of #2767