Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wait-for-it (to later replace Dockerize) #3503

Merged
merged 1 commit into from Oct 15, 2021

Conversation

jnm
Copy link
Member

@jnm jnm commented Oct 14, 2021

Dockerize recommends installing only by binary, which supports only limited architectures (e.g. not s390x).

This change supports kobotoolbox/kobo-docker#322, which adjusts the container startup scripts to use wait-for-it.

Also adds python3-virtualenv to the apt-get install command, for better compatibility with other base images. This doesn't appear to cause any problems with nikolaik/python-nodejs:python3.8-nodejs10.

(and I alphabetized the Debian packages, too 馃槈)

Description

Use a different tool that works with a variety of CPU architectures when waiting for needed services to start

Dockerize recommends installing only by binary, which supports only
limited architectures (e.g. not s390x).

This change supports kobotoolbox/kobo-docker#322, which adjusts the
container startup scripts to use `wait-for-it`
@noliveleger noliveleger merged commit 71feb52 into master Oct 15, 2021
@noliveleger noliveleger deleted the replace-dockerize branch October 15, 2021 14:42
jdugh pushed a commit to geohyd/kpi that referenced this pull request Nov 21, 2022
Install `wait-for-it` (to later replace Dockerize)
jdugh pushed a commit to geohyd/kpi that referenced this pull request Nov 13, 2023
Install `wait-for-it` (to later replace Dockerize)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants