Debug toolbar enable #3747
Merged
Debug toolbar enable #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
approved these changes
Apr 7, 2022
|
I know way back in the day there was no SHOW_TOOLBAR_CALLBACK option and I always hated setting my always changing DHCP ip address or figuring out god knows what some proxy thought I my ip was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For development, add
DEBUG_TOOLBARenvironment variable to enable django-debug-toolbar.Implementation
Currently one must look up their internal IP address as seen by the docker container to enable django debug toolbar. Which is only ever enabled in dev anyway. Instead, we can control this via a environment variable. In dev, set
DEBUG_TOOLBARto "True" to enable it. This does not work in other environments, where debug toolbar isn't enabled at all.