Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission assignments bug fix #3869

Merged
merged 3 commits into from Jun 14, 2022
Merged

Conversation

noliveleger
Copy link
Contributor

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Save permission assignments correctly when usernames start with the same letter but contain non alphanumeric characters (such as _) and have a mix of upper and lower case.

Related issues

Fixes #3864

jnm and others added 2 commits June 14, 2022 12:41
discrepancies between PostgreSQL and Python sorting. See #3864

ATTENTION: this needs unit tests!
@noliveleger noliveleger added CRITICAL Red alert! Fix me ASAP! API Changes related to API endpoints bug-fix Back end labels Jun 14, 2022
@noliveleger noliveleger requested a review from bufke June 14, 2022 18:36
@noliveleger noliveleger marked this pull request as ready for review June 14, 2022 18:57
@bufke
Copy link
Contributor

bufke commented Jun 14, 2022

This introduces 2 additional DB queries on the bulk endpoint. Not blocking. If you know why, it would be nice to address if it was possible. I didn't dig too much into it.

@bufke bufke merged commit edbe6e3 into 2.022.16a Jun 14, 2022
@noliveleger noliveleger deleted the 3864-permission-sorting-issue branch June 15, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes related to API endpoints Back end bug-fix CRITICAL Red alert! Fix me ASAP!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants