New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SearchBox and use it in Project Views code #4310
Merged
p2edwards
merged 13 commits into
feature/my-projects
from
4063-use-searchbox-in-project-views
Mar 21, 2023
Merged
Update SearchBox and use it in Project Views code #4310
p2edwards
merged 13 commits into
feature/my-projects
from
4063-use-searchbox-in-project-views
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e AccountMenu from it
p2edwards
changed the base branch from
4209-my-projects-redo
to
feature/my-projects
March 8, 2023 17:18
p2edwards
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays search box for My Projects and Project Views routes.
Code Review Notes
This changes a few things:
MainHeader
component to better directoryAccountMenu
component (out ofMainHeader
) and change to TypeScriptHeaderTitleEditor
componentSearchBox
componentsearchBoxStore
to MobX and update all code that was using itcustomViewStore
to use newsearchBoxStore
to fetch assets filtered by search phraseGeneral idea is to have this
searchBoxStore
being the singe source of truth for search box input. Every component or store that needs to know search phrase is using it now.searchBoxStore
is handling only single context at a time - that is why each piece of code that is using it, needs to register unique context id first. This is because some stores are working even after switching routes and we want to avoid unnecessary calls.Related issues
Fixes #4063