Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a request callback method for dj-stripe #4333

Merged

Conversation

JacquelineMorrissette
Copy link
Contributor

@JacquelineMorrissette JacquelineMorrissette commented Mar 10, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Create a callback function for dj-stripe to use a custom subscriber model

Related issues

Other Notes

The need for a callback function is supposed to be depreciated according to the stripe documentation, but errors are thrown when using the djstripe_sync_models management command. The function can do absolutely nothing, it just needs to exist

Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this approved and good to merge once you review my comments. I don't need to re-review. Thanks.

kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Show resolved Hide resolved
@JacquelineMorrissette JacquelineMorrissette force-pushed the add-djstripe-subscriber-model-callback branch from 025c7d8 to f917b0f Compare March 10, 2023 22:22
@JacquelineMorrissette JacquelineMorrissette merged commit a340201 into feature/billing Mar 10, 2023
@JacquelineMorrissette JacquelineMorrissette deleted the add-djstripe-subscriber-model-callback branch March 10, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants