Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success message after Stripe checkout #4392

Merged
merged 19 commits into from Apr 5, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Mar 29, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Adds a success popup when a user returns from a successful transaction at Stripe.

Related issues

Notes

Will return a message telling the user to wait a few minutes and refresh the page if their subscription hasn't yet been updated locally.

This doesn't make any API calls, it just sets the price ID in the return URL when we generate the checkout link. Then when the user comes back from Stripe, it checks that price ID against the list of current subscriptions. I had to pull in some unmerged changes from feature/billing to test it properly.

Screenshot

image

@LMNTL LMNTL requested a review from srartese March 29, 2023 19:44
@LMNTL LMNTL mentioned this pull request Mar 29, 2023
7 tasks
@bufke bufke self-requested a review April 4, 2023 18:34
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My change requests are minor, please proceed to merge once you review them.

kobo/apps/stripe/views.py Outdated Show resolved Hide resolved
kobo/apps/stripe/views.py Show resolved Hide resolved
kobo/apps/stripe/serializers.py Show resolved Hide resolved
@LMNTL LMNTL merged commit 31a6de7 into feature/add-subscription-tiers Apr 5, 2023
4 checks passed
@LMNTL LMNTL deleted the feature/stripe-success-message branch April 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants