New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add success message after Stripe checkout #4392
Merged
LMNTL
merged 19 commits into
feature/add-subscription-tiers
from
feature/stripe-success-message
Apr 5, 2023
Merged
Add success message after Stripe checkout #4392
LMNTL
merged 19 commits into
feature/add-subscription-tiers
from
feature/stripe-success-message
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufke
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My change requests are minor, please proceed to merge once you review them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds a success popup when a user returns from a successful transaction at Stripe.
Related issues
Notes
Will return a message telling the user to wait a few minutes and refresh the page if their subscription hasn't yet been updated locally.
This doesn't make any API calls, it just sets the price ID in the return URL when we generate the checkout link. Then when the user comes back from Stripe, it checks that price ID against the list of current subscriptions. I had to pull in some unmerged changes from
feature/billing
to test it properly.Screenshot