Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/4422 your plan show only on annual or monthly #4437

Merged

Conversation

srartese
Copy link
Contributor

@srartese srartese commented May 9, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

When page redirects the banner now only shows on the monthly/annual plan you upgraded to when you toggle between the two filters. It will load the filter to show based on what you are subscribed to. If there is no plan subscribed then show annual community plan by default. When subscribed to the pro plan show on the opposite filter a 'change plan' button so the user has a call to action when their plan is not visible.

Related issues

#4422

@srartese srartese requested a review from bufke May 9, 2023 05:39
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make it more obvious what the current plan is.

…fix/4422-your-plan-show-only-on-annual-or-monthly
…'Change plan' button as option for opposite subscribed plan option
…fix/4422-your-plan-show-only-on-annual-or-monthly

# Conflicts:
#	jsapp/js/account/plan.component.tsx
@srartese srartese requested a review from bufke May 15, 2023 15:33
@srartese srartese requested a review from LMNTL May 17, 2023 23:20
@srartese srartese self-assigned this May 18, 2023
@LMNTL LMNTL merged commit ec2eb74 into feature/billing May 22, 2023
4 checks passed
@LMNTL LMNTL deleted the bugfix/4422-your-plan-show-only-on-annual-or-monthly branch May 22, 2023 18:36
@LMNTL LMNTL linked an issue May 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'your plan' shows on both monthly and annual plans after upgrading
3 participants