New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/4422 your plan show only on annual or monthly #4437
Merged
LMNTL
merged 12 commits into
feature/billing
from
bugfix/4422-your-plan-show-only-on-annual-or-monthly
May 22, 2023
Merged
Bugfix/4422 your plan show only on annual or monthly #4437
LMNTL
merged 12 commits into
feature/billing
from
bugfix/4422-your-plan-show-only-on-annual-or-monthly
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lbox/kpi into bugfix/4422-your-plan-show-only-on-annual-or-monthly
bufke
approved these changes
May 9, 2023
bufke
requested changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make it more obvious what the current plan is.
…fix/4422-your-plan-show-only-on-annual-or-monthly
…n-annual-or-monthly
…'Change plan' button as option for opposite subscribed plan option
…fix/4422-your-plan-show-only-on-annual-or-monthly # Conflicts: # jsapp/js/account/plan.component.tsx
bufke
requested changes
May 15, 2023
LMNTL
requested changes
May 18, 2023
LMNTL
requested changes
May 18, 2023
LMNTL
requested changes
May 19, 2023
LMNTL
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
When page redirects the banner now only shows on the monthly/annual plan you upgraded to when you toggle between the two filters. It will load the filter to show based on what you are subscribed to. If there is no plan subscribed then show annual community plan by default. When subscribed to the pro plan show on the opposite filter a 'change plan' button so the user has a call to action when their plan is not visible.
Related issues
#4422