Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update radio and checkbox styles #4442

Merged
merged 5 commits into from May 20, 2023
Merged

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented May 17, 2023

Description

Simplified and more modern styles for checkboxes and radio inputs

Code Review Notes

Few things here

  • I decided to split the shared styles file, as there was not much gain from it and it was blocking us from moving forward and making the SCSS code harder to grasp
  • I didn't drop BEM, as unfortunately both <Radio> and <Checkbox> components are being used in few Old Code™ places
  • Added isClearable option to <Radio>, to make it optionally unselectable. The default value is keeping current status quo

Related issues

Fixes #4306

@magicznyleszek magicznyleszek changed the base branch from main to beta May 17, 2023 10:09
@magicznyleszek magicznyleszek marked this pull request as ready for review May 17, 2023 10:11
@magicznyleszek magicznyleszek requested a review from duvld May 17, 2023 10:52
p2edwards added a commit that referenced this pull request May 18, 2023
- Re-center new checkbox, adapt borders and colors
- Add global keyboard focus styles to checkbox and radio
@duvld duvld merged commit 2aec663 into beta May 20, 2023
4 checks passed
@duvld duvld deleted the 4306-update-radio-and-checkbox-styles branch May 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checkbox styles
2 participants