Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asset list from user serializer #4479

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Remove asset list from user serializer #4479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef273e6
Remove list of asset URLs from user serializer
jnm Jun 7, 2023
3798cc2
Remove `serializer_class` attribute from v1…
jnm Jun 7, 2023
c7aaea8
Remove unused v1 user serializer
jnm Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion kpi/serializers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@
from .v1.tag import TagSerializer
from .create_user import CreateUserSerializer
from .current_user import CurrentUserSerializer
from .v1.user import UserSerializer
from .v1.user_asset_subscription import UserAssetSubscriptionSerializer
19 changes: 0 additions & 19 deletions kpi/serializers/v1/user.py
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions kpi/serializers/v2/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ class UserSerializer(serializers.HyperlinkedModelSerializer):

url = HyperlinkedIdentityField(
lookup_field='username', view_name='user-detail')
assets = PaginatedApiField(
serializer_class=AssetUrlListSerializer
)
date_joined = serializers.SerializerMethodField()
public_collection_subscribers_count = serializers.SerializerMethodField()
public_collections_count = serializers.SerializerMethodField()
Expand All @@ -33,7 +30,6 @@ class Meta:
model = User
fields = ('url',
'username',
'assets',
'date_joined',
'public_collection_subscribers_count',
'public_collections_count',
Expand Down
4 changes: 1 addition & 3 deletions kpi/views/v1/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# coding: utf-8
from kpi.serializers import UserSerializer
from kpi.views.v2.user import UserViewSet as UserViewSetV2


Expand All @@ -12,5 +11,4 @@ class UserViewSet(UserViewSetV2):
This viewset provides only the `detail` action; `list` is *not* provided to
avoid disclosing every username in the database
"""

serializer_class = UserSerializer
pass