Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Validation Configuration #4482

Merged
merged 22 commits into from Jul 18, 2023
Merged

Password Validation Configuration #4482

merged 22 commits into from Jul 18, 2023

Conversation

JacquelineMorrissette
Copy link
Contributor

@JacquelineMorrissette JacquelineMorrissette commented Jun 8, 2023 •
edited by noliveleger

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Add password validation configuration to Constance and add variables to the /environment endpoint

Related issues

Closes #4462
Closes #4481

@JacquelineMorrissette JacquelineMorrissette added API Changes related to API endpoints Back end labels Jun 8, 2023
@JacquelineMorrissette JacquelineMorrissette linked an issue Jun 8, 2023 that may be closed by this pull request
Build a way to configure custom requirements in Constance #4462
Closed
magicznyleszek
magicznyleszek reviewed Jun 9, 2023
View reviewed changes
kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kpi/views/environment.py Outdated Show resolved Hide resolved
kobo/settings/base.py Show resolved Hide resolved
@noliveleger
Add custom classes for password validation
998fe31
@noliveleger
Update django-constance to 2.9.1
396cdef
@noliveleger
Add password validation classes
3c07cfc
@noliveleger
Unit tests
00c01d0
@noliveleger
Fix error when validating passwords with user's attributes
6308aeb
@noliveleger
Merge branch 'feature/password-complexity' into 4462-configure-custom…
7ebc783 
…-reqs
@noliveleger
Merge branch '4462-configure-custom-reqs' into 4462-password-validati…
b59cab7 
…on-classes
@noliveleger
Void lru cache after uploading a new custom passwords file
1de51a8
@noliveleger
Make /me endpoint use Django password validation
0d35bf1
@noliveleger
Add unit test for /me endpoint for password validation
365e69a
@noliveleger
Merge branch 'feature/password-complexity' into 4462-configure-custom…
008dbdf 
…-reqs
@noliveleger
Merge branch '4462-configure-custom-reqs' into 4462-password-validati…
12a4623 
…on-classes
@noliveleger
Fix migrations conflict
82778a5
@noliveleger
Deactivate password validation in unit tests for django-allauth emails
31ebcdc
@noliveleger
Use ConfigurationFileSlug.choices() instead of ConfigurationFile cons…
dfa1b8c 
…tants
@noliveleger
Deactivate password validation in unit tests for registration
9fb66ce
@noliveleger
Fix caching in unit tests
2a13ec5
@noliveleger
Apply requested changes for PR#4533
f24bd92
@noliveleger
Merge pull request #4533 from kobotoolbox/4462-password-validation-cl…
c89f067 
…asses

Validate password based on (Constance) settings in Django Admin
@noliveleger
Merge branch 'feature/password-complexity' into 4462-configure-custom…
56c0b57 
…-reqs

 # Conflicts:
 #	kpi/tests/api/test_api_environment.py
@noliveleger
Merge branch '4462-configure-custom-reqs' of github.com:kobotoolbox/k…
3c674fd 
…pi into 4462-configure-custom-reqs

 # Conflicts:
 #	kobo/settings/base.py
@noliveleger noliveleger merged commit e7871fa into feature/password-complexity Jul 18, 2023
3 checks passed
@noliveleger noliveleger deleted the 4462-configure-custom-reqs branch July 18, 2023 13:39
@noliveleger noliveleger self-requested a review July 18, 2023 13:39
@noliveleger noliveleger self-assigned this Jul 18, 2023
@magicznyleszek magicznyleszek linked an issue Aug 1, 2023 that may be closed by this pull request
Config for zxcvbn disabling #4481
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicznyleszek magicznyleszek magicznyleszek left review comments

@noliveleger noliveleger Awaiting requested review from noliveleger

Assignees

@noliveleger noliveleger

Labels
API Changes related to API endpoints Back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config for zxcvbn disabling Build a way to configure custom requirements in Constance
3 participants
@JacquelineMorrissette @magicznyleszek @noliveleger