Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only one markdown dependency for markdown fields in Django Admin #4483

Merged
merged 11 commits into from Aug 14, 2023
Merged

Use only one markdown dependency for markdown fields in Django Admin #4483

merged 11 commits into from Aug 14, 2023

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Jun 9, 2023 •
edited

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Replace django-markitup with markdownx everywhere.

Additional info

A cronjob has been added to clean-up orphan uploaded files

@noliveleger noliveleger requested a review from jnm June 9, 2023 15:37
@noliveleger noliveleger added Back end enhancement Ideas, improvements and features labels Jun 9, 2023
@noliveleger noliveleger marked this pull request as draft June 9, 2023 15:37
@noliveleger noliveleger marked this pull request as ready for review June 9, 2023 15:58
jnm
jnm approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after demo and high-level review (not line-by-line)

@jnm jnm merged commit 0672fa6 into feature/enketo-disclaimer Aug 14, 2023
3 of 4 checks passed
@jnm jnm deleted the refactor-markdownx branch August 14, 2023 20:52
@jnm jnm mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm approved these changes

Assignees

@jnm jnm

Labels
Back end enhancement Ideas, improvements and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noliveleger @jnm