Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labeling/ordering of transcripts/translations for grouped audio questions #4487

Merged
merged 13 commits into from Sep 21, 2023

Conversation

srartese
Copy link
Contributor

@srartese srartese commented Jun 13, 2023

Description

Place transcripts and translations immediately after their related audio questions, and use field labels instead of XML values when 'Labels' is selected in the Table display option.

These fixes for grouped audio apply to the table view column headers and the single submission model rows.

Related issues

Fixes #4394
Fixes #4395

Reviewer notes

Diffs from commits ignored in .git-blame-ignore-revs commits still show up in the 'Files changed' view for reviewers. So it's still better to isolate formatting commits to their own PR.

@srartese srartese self-assigned this Jun 13, 2023
@srartese srartese requested a review from dorey June 13, 2023 22:03
@jnm jnm requested review from p2edwards and removed request for dorey September 18, 2023 15:52
@jnm jnm assigned p2edwards and unassigned srartese Sep 18, 2023
@p2edwards p2edwards changed the title NLP formatting clean up, use the correct labels and ordering for grouped transcript and translation fields, and grouped questions appear in correct order Improve labeling/ordering of transcripts/translations for grouped audio questions Sep 20, 2023
Copy link
Contributor

@p2edwards p2edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few commits with a fix and some code simplifications, and I've updated the PR description for the release notes.

@p2edwards p2edwards changed the base branch from beta to release/2.023.37 September 21, 2023 17:08
@p2edwards
Copy link
Contributor

Rebased recent changes on current release branch.

@p2edwards p2edwards merged commit 70f0349 into release/2.023.37 Sep 21, 2023
4 checks passed
@p2edwards p2edwards deleted the 4394-nlp-formatting-fix branch September 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants