New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve labeling/ordering of transcripts/translations for grouped audio questions #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2edwards
changed the title
NLP formatting clean up, use the correct labels and ordering for grouped transcript and translation fields, and grouped questions appear in correct order
Improve labeling/ordering of transcripts/translations for grouped audio questions
Sep 20, 2023
p2edwards
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few commits with a fix and some code simplifications, and I've updated the PR description for the release notes.
…on supplemental column headers (transcripts/translations).
…if 'Show Group Names' is enabled by the user
p2edwards
force-pushed
the
4394-nlp-formatting-fix
branch
from
September 21, 2023 17:07
16951ea
to
341f76a
Compare
Rebased recent changes on current release branch. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Place transcripts and translations immediately after their related audio questions, and use field labels instead of XML values when 'Labels' is selected in the Table display option.
These fixes for grouped audio apply to the table view column headers and the single submission model rows.
Related issues
Fixes #4394
Fixes #4395
Reviewer notes
Diffs from commits ignored in
.git-blame-ignore-revs
commits still show up in the 'Files changed' view for reviewers. So it's still better to isolate formatting commits to their own PR.