Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to User and Project metadata #4497

Merged
merged 14 commits into from Jul 27, 2023
Merged

Add labels to User and Project metadata #4497

merged 14 commits into from Jul 27, 2023

Conversation

JacquelineMorrissette
Copy link
Contributor

@JacquelineMorrissette JacquelineMorrissette commented Jun 14, 2023 •
edited

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Add custom label support and custom translation support for User and Project Metadata fields

Related issues

closes #4488
closes #4492
part of #4490
part of #4491

This was linked to issues Jun 14, 2023
Allow User Metadata labels to be configured in Django Admin interface #4488
Closed
Allow Project Metadata Fields to be configured in Django Admin interface #4492
Closed
Add support for Project Metadata custom translations for label #4494
Closed
@JacquelineMorrissette JacquelineMorrissette force-pushed the add-label-to-user-projects-metadata branch from 57fb5bb to 4b7ed95 Compare June 14, 2023 19:20
@JacquelineMorrissette JacquelineMorrissette force-pushed the add-label-to-user-projects-metadata branch from d30c681 to bff0901 Compare July 5, 2023 01:10
jnm
jnm requested changes Jul 21, 2023
View reviewed changes
kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kpi/fields/jsonschema_form_field.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kobo/settings/base.py Outdated Show resolved Hide resolved
kpi/tests/api/test_api_environment.py Outdated Show resolved Hide resolved
@jnm jnm removed the request for review from noliveleger July 21, 2023 23:42
@jnm jnm assigned jnm and unassigned noliveleger Jul 21, 2023
jnm added 6 commits July 27, 2023 16:17
@jnm
Merge branch 'feature/user-project-metadata' into add-label-to-user-p…
9b92892 
…rojects-metadata
@jnm
Merge branch 'add-label-to-user-projects-metadata' into custom-transl…
9838f54 
…ations
@jnm
Add minor readability improvements
084b381
@jnm
Use context managers to improve readability
8c9f5fa 
…and make a few other improvements to user metadata form tests
@jnm
Merge pull request #4527 from kobotoolbox/custom-translations
6060ea9 
Add back-end support for custom translations of labels for user metadata fields
@jnm
Change very minor things
1533a42 
* `\n\r` -> `\n\n`
* Remove stray whitespace
@jnm jnm merged commit 4951343 into feature/user-project-metadata Jul 27, 2023
3 checks passed
@jnm jnm deleted the add-label-to-user-projects-metadata branch July 27, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm requested changes

Assignees

@jnm jnm

Labels
Back end
Projects
None yet
Milestone
No milestone
3 participants
@JacquelineMorrissette @jnm @noliveleger