-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React Router to 6.14.2 and use upstream usePrompt #4505
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c41f766 - Browse repository at this point
Copy the full SHA c41f766View commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1790aaa - Browse repository at this point
Copy the full SHA 1790aaaView commit details
Commits on Jul 5, 2023
-
Merge from beta and resolve package-lock.json conflicts, by…
…using the package-lock.json from beta and re-running npm@8.5.5 install
Configuration menu - View commit details
-
Copy full SHA for 47cd995 - Browse repository at this point
Copy the full SHA 47cd995View commit details
Commits on Jul 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ccbae1b - Browse repository at this point
Copy the full SHA ccbae1bView commit details -
Change
router?.navigate(…)
torouter!.navigate(…)
If any of these functions are called while router is still null, that means our setTimeout(()=>…) dependency injection didn't work. Let's make that show up as an error in the browser console, rather than silently failing to navigate.
Configuration menu - View commit details
-
Copy full SHA for bd1015f - Browse repository at this point
Copy the full SHA bd1015fView commit details
Commits on Jul 12, 2023
-
Pin exact version of react-router-dom (to 6.14.1)
I'd like to make sure whenever we update this library, we do it as a focused and intentional endeavor, where someone gets to read the patch notes, and decide how much manual QA is needed. Patch notes for react-router: - https://github.com/remix-run/react-router/releases That might be true even if we weren't using `unstable_` API's. An alternative would be to use `~6.14.1` to stay on `6.14.x`, allowing some `npm` commands to sometimes update patch versions if they exist. --- Package-lock.json already specifies 6.14.1 prior to this commit, because it updated while I was resolving the merge conflict (6.14.1 qualifies as ^6.13.0).
Configuration menu - View commit details
-
Copy full SHA for 5bd385b - Browse repository at this point
Copy the full SHA 5bd385bView commit details
Commits on Jul 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0057e0e - Browse repository at this point
Copy the full SHA 0057e0eView commit details
Commits on Jul 20, 2023
-
Fix language selector focus outline and click height
Language selector had an extra box outline introduced by #4207 and the click height was short. (UI fix not related to current PR, this came up while testing the form processing route.)
Configuration menu - View commit details
-
Copy full SHA for 53a7d27 - Browse repository at this point
Copy the full SHA 53a7d27View commit details
Commits on Jul 21, 2023
-
Remove /forms/:uid/settings/kobocat
Superceded by /forms/:uid/settings/media
Configuration menu - View commit details
-
Copy full SHA for 5195f7c - Browse repository at this point
Copy the full SHA 5195f7cView commit details -
(auto/format) Apply automated eslint and prettier to map.es6
formatting-only commit
Configuration menu - View commit details
-
Copy full SHA for be3a9b6 - Browse repository at this point
Copy the full SHA be3a9b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01b00c0 - Browse repository at this point
Copy the full SHA 01b00c0View commit details -
Apply manual ESLint fixes to map.es6
- Manually hoist variables to make scope clearer and use 'let' - Carefully replace 8 loose comparisons with strict ones (===, !==) - https://dorey.github.io/JavaScript-Equality-Table/ was useful here
Configuration menu - View commit details
-
Copy full SHA for 16f242b - Browse repository at this point
Copy the full SHA 16f242bView commit details -
Fix a map screen crash due to translations not being an array
It seems asset.content.translations can be undefined if you have a form with 0 questions, which is pretty uncommon but it leads to a full-page crash here. Fix the same crash when it appears in the data table settings menu, and on the data reports page.
Configuration menu - View commit details
-
Copy full SHA for bcdbaf0 - Browse repository at this point
Copy the full SHA bcdbaf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 019e386 - Browse repository at this point
Copy the full SHA 019e386View commit details -
Retain the FORM_RESET route for now (/forms/:uid/reset) #3925
…as it still has some impact on subroute behavior.
Configuration menu - View commit details
-
Copy full SHA for 9cacb3f - Browse repository at this point
Copy the full SHA 9cacb3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f6160 - Browse repository at this point
Copy the full SHA b2f6160View commit details -
Configuration menu - View commit details
-
Copy full SHA for 968da59 - Browse repository at this point
Copy the full SHA 968da59View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d2f2f3b - Browse repository at this point
Copy the full SHA d2f2f3bView commit details