Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Router to 6.14.2 and use upstream usePrompt #4505

Merged
merged 18 commits into from
Jul 24, 2023
Merged

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    c41f766 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    1790aaa View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge from beta and resolve package-lock.json conflicts, by…

    …using the package-lock.json from beta and re-running npm@8.5.5 install
    p2edwards committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    47cd995 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    ccbae1b View commit details
    Browse the repository at this point in the history
  2. Change router?.navigate(…) to router!.navigate(…)

    If any of these functions are called while router is still null, that
    means our setTimeout(()=>…) dependency injection didn't work.
    
    Let's make that show up as an error in the browser console, rather than
    silently failing to navigate.
    p2edwards committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bd1015f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Pin exact version of react-router-dom (to 6.14.1)

    I'd like to make sure whenever we update this library, we do it as a
    focused and intentional endeavor, where someone gets to read the patch
    notes, and decide how much manual QA is needed.
    
    Patch notes for react-router:
    
    - https://github.com/remix-run/react-router/releases
    
    That might be true even if we weren't using `unstable_` API's.
    
    An alternative would be to use `~6.14.1` to stay on `6.14.x`, allowing
    some `npm` commands to sometimes update patch versions if they exist.
    
    ---
    
    Package-lock.json already specifies 6.14.1 prior to this commit, because
    it updated while I was resolving the merge conflict (6.14.1 qualifies as
    ^6.13.0).
    p2edwards committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5bd385b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    0057e0e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Fix language selector focus outline and click height

    Language selector had an extra box outline introduced by #4207
    and the click height was short.
    
    (UI fix not related to current PR, this came up while testing the
    form processing route.)
    p2edwards committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    53a7d27 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Remove /forms/:uid/settings/kobocat

    Superceded by /forms/:uid/settings/media
    p2edwards committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    5195f7c View commit details
    Browse the repository at this point in the history
  2. (auto/format) Apply automated eslint and prettier to map.es6

    formatting-only commit
    p2edwards committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    be3a9b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01b00c0 View commit details
    Browse the repository at this point in the history
  4. Apply manual ESLint fixes to map.es6

    - Manually hoist variables to make scope clearer and use 'let'
    - Carefully replace 8 loose comparisons with strict ones (===, !==)
      - https://dorey.github.io/JavaScript-Equality-Table/ was useful here
    p2edwards committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    16f242b View commit details
    Browse the repository at this point in the history
  5. Fix a map screen crash due to translations not being an array

    It seems asset.content.translations can be undefined if you have a form
    with 0 questions, which is pretty uncommon but it leads to a full-page
    crash here.
    
    Fix the same crash when it appears in the data table settings menu,
    and on the data reports page.
    p2edwards committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bcdbaf0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    019e386 View commit details
    Browse the repository at this point in the history
  7. Retain the FORM_RESET route for now (/forms/:uid/reset) #3925

    …as it still has some impact on subroute behavior.
    p2edwards committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9cacb3f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b2f6160 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    968da59 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    d2f2f3b View commit details
    Browse the repository at this point in the history