Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting SSO config fully in env vars and support multiple public OIDC providers #4508

Merged
merged 7 commits into from Jun 28, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Jun 22, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Adds front-end support for multiple OIDC SSO providers.

Notes

Also allows fully setting the configuration of an OIDC provider from environment variables (for Google and Microsoft; additional values can be added later as necessary). OIDC providers that are set entirely in the environment variables will not show up on the frontend, as if they had "Social App Custom Data" defined. They can be accessed by visiting their hidden links:

/accounts/{Social provider ID}/login to login
/accounts/{Social provider ID}/login/?process=connect to setup

@LMNTL LMNTL requested a review from bufke June 22, 2023 19:47
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty basic and it worked for me testing. Ok to merge once my comments are reviewed.

@LMNTL LMNTL requested a review from bufke June 28, 2023 17:08
@bufke bufke merged commit a1fa14e into beta Jun 28, 2023
4 checks passed
@LMNTL LMNTL deleted the feature/sso-bugfixes branch July 28, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants