Typescriptize MainHeader component #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2edwards
reviewed
Jul 11, 2023
jsapp/js/assetUtils.ts
Outdated
| @@ -269,40 +270,40 @@ export function isAssetPublic(permissions?: Permission[]) { | |||
| * For getting the icon class name for given asset type. Returned string always | |||
| * contains two class names: base `k-icon` and respective CSS class name. | |||
There was a problem hiding this comment.
Is this comment still accurate?
There was a problem hiding this comment.
Updated the comment :)
p2edwards
reviewed
Jul 11, 2023
| if (sessionStore.currentAccount?.git_rev) { | ||
| if ( | ||
| 'git_rev' in sessionStore.currentAccount && | ||
| sessionStore.currentAccount?.git_rev |
There was a problem hiding this comment.
I don't fully understand the 2nd check — 'git_rev' in sessionStore.currentAccount would throw an error if sessionStore.currentAccount isn't an object
There was a problem hiding this comment.
Right, I've changed it to check if both of the values we use for rendering are strings.
…ponent # Conflicts: # jsapp/js/app.js # jsapp/js/components/header/mainHeader.component.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal code improvements.
Code Review Notes
I had to simplify it a bit, but didn't want to go full refactor on it. I need this to be TS for some other work. Since it's not a small change, I'm not entirely sure I want it merged into
feature/my-projects, but still want it reviewed. The plan would be to wait for the feature to be merged (soon 🤞), and then change base of this PR to the other feature branch I'm working on.