Remove unused variable report__base #4552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm
approved these changes
Jul 24, 2023
p2edwards
reviewed
Jul 25, 2023
| var deployment__identifier = ''; | ||
|
|
||
| if (this.state.uid != undefined) { | ||
| if (this.state.deployment__identifier != undefined) { | ||
| deployment__identifier = this.state.deployment__identifier; | ||
| report__base = deployment__identifier.replace('/forms/', '/reports/'); | ||
| } | ||
| switch (this.props.router.location.pathname) { |
There was a problem hiding this comment.
I would have suggested removing var deployment__identifier = '' and the whole if (…deployment__identifier…) { … } block, as it appears to be unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report__base was used in FORM_REPORT_OLD which was already removed. The variable is set but never read. This change removes it.