Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save date of password change and flag it as valid #4558

Merged
merged 6 commits into from Aug 7, 2023
Merged

Save date of password change and flag it as valid #4558

merged 6 commits into from Aug 7, 2023

Conversation

noliveleger
Copy link
Contributor

Description

When users change (or reset) their password, the date/time of this event (only the last one) is saved.
Their password is also flagged as valid because it has passed all the password rules.

Related issues

Part of #4473

@JacquelineMorrissette
Copy link
Contributor

I found one bug that I'm not sure if it's related to this PR or not, but:

<html><body>
<!--StartFragment--><pre class="exception_value">'CustomRulesValidator' object has no attribute 'get_help_text'</pre>
  

Request Method: | GET
-- | --
http://10.0.0.91:8080/admin/auth/user/add/
3.2.15
AttributeError
'CustomRulesValidator' object has no attribute 'get_help_text'
/opt/venv/lib/python3.10/site-packages/django/contrib/auth/password_validation.py, line 74, in password_validators_help_texts
/opt/venv/bin/python
3.10.12
['/srv/src/kpi',  '/srv/src/kpi',  '/usr/local/lib/python310.zip',  '/usr/local/lib/python3.10',  '/usr/local/lib/python3.10/lib-dynload',  '/opt/venv/lib/python3.10/site-packages',  '/opt/venv/src/formpack/src',  '/opt/venv/src/ssrf-protect/src',  '/opt/venv/src/python-digest',  '/opt/venv/src/django-digest',  '/opt/venv/src/kobo-service-account/src']

<!--EndFragment-->
</body>
</html>

To recreate, go to /admin/auth/user/add/

@JacquelineMorrissette
Copy link
Contributor

JacquelineMorrissette commented Jul 28, 2023 •
edited by noliveleger

Another bug that may have been created in one of the other PRs:
image
It's missing the first password field

@noliveleger
Copy link
Contributor Author

I found one bug that I'm not sure if it's related to this PR or not, but:

To recreate, go to /admin/auth/user/add/

🤔 I'll look at it ;-) Good catch

@noliveleger
Copy link
Contributor Author

I found one bug that I'm not sure if it's related to this PR or not, but:

<html><body>
<!--StartFragment--><pre class="exception_value">'CustomRulesValidator' object has no attribute 'get_help_text'</pre>
  

Request Method: | GET
-- | --
http://10.0.0.91:8080/admin/auth/user/add/
3.2.15
AttributeError
'CustomRulesValidator' object has no attribute 'get_help_text'
/opt/venv/lib/python3.10/site-packages/django/contrib/auth/password_validation.py, line 74, in password_validators_help_texts
/opt/venv/bin/python
3.10.12
['/srv/src/kpi',  '/srv/src/kpi',  '/usr/local/lib/python310.zip',  '/usr/local/lib/python3.10',  '/usr/local/lib/python3.10/lib-dynload',  '/opt/venv/lib/python3.10/site-packages',  '/opt/venv/src/formpack/src',  '/opt/venv/src/ssrf-protect/src',  '/opt/venv/src/python-digest',  '/opt/venv/src/django-digest',  '/opt/venv/src/kobo-service-account/src']

<!--EndFragment-->
</body>
</html>

To recreate, go to /admin/auth/user/add/

Fixed

@JacquelineMorrissette JacquelineMorrissette merged commit 5aebf5b into feature/password-complexity Aug 7, 2023
4 checks passed
@JacquelineMorrissette JacquelineMorrissette deleted the 4473-track-password-changes branch August 7, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquelineMorrissette JacquelineMorrissette Awaiting requested review from JacquelineMorrissette

Assignees

@JacquelineMorrissette JacquelineMorrissette

Labels
Back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noliveleger @JacquelineMorrissette