New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage limits 2fa fixes #4561
Merged
noliveleger
merged 14 commits into
feature/usage-limits
from
feature/usage-limits-2fa-fixes
Aug 2, 2023
Merged
Usage limits 2fa fixes #4561
noliveleger
merged 14 commits into
feature/usage-limits
from
feature/usage-limits-2fa-fixes
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
reviewed
Aug 1, 2023
noliveleger
requested changes
Aug 2, 2023
jsapp/js/actions/mfaActions.ts
Outdated
if (!envStore.data.stripe_public_key) { | ||
// If Stripe isn't enabled on the site, don't restrict MFA access | ||
mfaActions.hasActiveSubscription.completed(true); | ||
mfaActions.getMfaAvailability.completed({ | ||
isMfaAvailable: hasMfaList && mfaAvailableToUser, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition does not work when MFA is enabled and there is not per-user availability list. MFA section never shows up.
It could be changed to isMfaAvailable: !hasMfaList || (hasMfaList && mfaAvailableToUser),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Small changes to how MFA configuration is sent to the browser.
Notes
The frontend environment variable
mfa_allowed
has been split into three values:mfa_allowed
: tracks whether MFA is enabled on the server levelmfa_per_user_availability
: tracks whether the current user has MFA per-user availability setmfa_has_availability_list
: tracks whether any users have MFA per-user availability set