New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass user email script using Amazon SES #4570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm
approved these changes
Aug 8, 2023
and min(quota_sends, remaining_sends) | ||
or quota_sends | ||
) | ||
string_sends = remaining_sends >= 0 and remaining_sends or "unlimited" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit, this took me an embarrassing amount of time to wrap my head around. I don't know if it's worth changing such well-tested code, but I'd offer for future consideration something like
string_sends = remaining_sends if remaining_sends > 0 else "unlimited"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Added a script to send broadcast emails to users using Amazon SES.
Notes
To test this, you'll need the environment variables
AWS_SECRET_ACCESS_KEY
,AWS_ACCESS_KEY_ID
, and eitherAWS_S3_REGION_NAME
orAWS_SES_REGION_NAME
to be set.Before running the script, make sure the constants at the top of the file are set. You'll need to create a blank HTML file in
/scripts/
and setEMAIL_HTML_FILENAME
to its file name, then do the same with a blank .txt file andEMAIL_TEXT_FILENAME
.You can run the script in test mode (doesn't send any emails) using:
./manage.py runscript mass_user_emails --script-args test
To force re-sending emails to users that have already been emailed:
./manage.py runscript mass_user_emails --script-args force