Block API endpoints access to users when their password has been invalidated by a superuser #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the base branch from
feature/password-complexity
to
4477-invalidated-password-screen
Base automatically changed from
4477-invalidated-password-screen
to
feature/password-complexity
August 8, 2023 19:01
noliveleger
force-pushed
the
4473-block-api-with-invalid-password
branch
from
e2062bf
to
78791db
Compare
noliveleger
changed the title
noliveleger
changed the title
…nvalid-password # Conflicts: # kobo/apps/accounts/tests/test_email.py
JacquelineMorrissette
requested changes
Aug 18, 2023
kobo/apps/subsequences/tests/test_submission_extras_api_post.py
Outdated
Show resolved
Hide resolved
kobo/apps/subsequences/tests/test_submission_extras_api_post.py
Outdated
Show resolved
Hide resolved
jnm
approved these changes
Aug 30, 2023
…o 4473-block-api-with-invalid-password
jnm
requested changes
Aug 30, 2023
|
Discovered by accident: if you become logged out somehow and then attempt to change your password from within the SPA, you get a 500 error: kpi/kpi/serializers/current_user.py Line 148 in db36eb0 |
Use fuzzy integer for tests which assert of number of queries
jnm
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #4473