Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring to get translated utilities at the same place #4590

Merged

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Aug 15, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Additional info

full_name property is back to name to avoid big migrations in existing environments.
And it is not possible to hide this field (even if it is still possible to toggle its required flag)

@noliveleger noliveleger requested a review from LMNTL August 15, 2023 20:57
@noliveleger noliveleger marked this pull request as draft August 15, 2023 20:57
@noliveleger noliveleger changed the base branch from feature/user-project-metadata to create-metadata-context-processor August 15, 2023 20:58
@noliveleger noliveleger force-pushed the refactor-metadata-fields-labels branch from 87be99e to 9da1b41 Compare August 15, 2023 21:05
Base automatically changed from create-metadata-context-processor to feature/user-project-metadata August 15, 2023 21:07
@noliveleger noliveleger force-pushed the refactor-metadata-fields-labels branch from 9da1b41 to a19d6a8 Compare August 15, 2023 21:12
@noliveleger noliveleger changed the title WIP - Refactor metadata fields labels Code refactoring to get translated utilities at the same place Aug 16, 2023
@noliveleger noliveleger force-pushed the refactor-metadata-fields-labels branch from a19d6a8 to 5a39ce4 Compare August 16, 2023 13:44
Copy link
Contributor

@LMNTL LMNTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to break it, seems solid. Didn't know you could use newlines in constance field descriptions, that's useful!

@noliveleger noliveleger marked this pull request as ready for review August 17, 2023 19:12
@noliveleger
Copy link
Contributor Author

I tried to break it, seems solid. Didn't know you could use newlines in constance field descriptions, that's useful!

I created a proof-of-concept with markdown support. I would need to create propose a PR on Constance repo. Maybe one day.

@noliveleger noliveleger merged commit 95c5afd into feature/user-project-metadata Aug 17, 2023
4 checks passed
@noliveleger noliveleger deleted the refactor-metadata-fields-labels branch August 17, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants