Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy/styling for usage limit banners and modals #4601

Merged
merged 24 commits into from Sep 11, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Aug 24, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Changed the text and styling of usage limit notifications for public servers.

Screenshots

image

Notes

Fixed an issue that was causing the usage page to not load when Stripe isn't enabled.

Added missing usage banners/modal to custom project view.

Added usage banners to Usage page.

If a user has some limits that are exceeded and some that are in the warning range, only show banners for exceeded limits.

Modals are only shown if the user is over the submission or storage limits.

I extracted the usage limits banners/modal into a reusable component, LimitNotifications.

I also added transitions to the Button common component - opacity, background color, and text color. I was tempted to do transition: all 0.2s, but that might be a bit too far :)

@LMNTL LMNTL requested a review from srartese August 28, 2023 19:28
@LMNTL LMNTL marked this pull request as draft August 29, 2023 14:10
@LMNTL LMNTL removed the request for review from srartese August 29, 2023 14:10
@LMNTL LMNTL marked this pull request as ready for review August 29, 2023 20:51
@LMNTL LMNTL requested a review from srartese August 29, 2023 20:51
@LMNTL LMNTL added the Front end label Sep 5, 2023
Copy link
Contributor

@srartese srartese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only two small things. I noticed looking at this figma design UI alignment of the icon is suppose to be upper left now instead of center for the red box on the modal.

Also smart to add the hover effects but I think its too hard to see it on the 'Upgrade now' button. Maybe we make that one darker on hover?

@LMNTL LMNTL requested a review from srartese September 7, 2023 17:01
Copy link
Contributor

@srartese srartese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover looks much better! The UI on the modal is still off, the links in the paragraph should be underlined and darker blue instead of the lighter blue it is now. Looks like it should be the same link styling as the banners. Also please shouldn't be part of that link. Figma screenshot below.
Screen Shot 2023-09-07 at 3 41 11 PM

@LMNTL
Copy link
Contributor Author

LMNTL commented Sep 8, 2023

@srartese Nice catch! I've updated those links and added some more changes to get closer to the Figma.

@LMNTL LMNTL requested a review from srartese September 8, 2023 18:10
@jnm jnm changed the base branch from beta to release/2.023.37 September 11, 2023 12:54
@LMNTL LMNTL merged commit 51eb4c6 into release/2.023.37 Sep 11, 2023
4 checks passed
@LMNTL LMNTL deleted the usage-limits-update-copy branch September 11, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants