New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy/styling for usage limit banners and modals #4601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only two small things. I noticed looking at this figma design UI alignment of the icon is suppose to be upper left now instead of center for the red box on the modal.
Also smart to add the hover effects but I think its too hard to see it on the 'Upgrade now' button. Maybe we make that one darker on hover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
show limit amount even if 0
make 'monthly'/'yearly' text in limit banners translatable
@srartese Nice catch! I've updated those links and added some more changes to get closer to the Figma. |
Checklist
Description
Changed the text and styling of usage limit notifications for public servers.
Screenshots
Notes
Fixed an issue that was causing the usage page to not load when Stripe isn't enabled.
Added missing usage banners/modal to custom project view.
Added usage banners to Usage page.
If a user has some limits that are exceeded and some that are in the warning range, only show banners for exceeded limits.
Modals are only shown if the user is over the submission or storage limits.
I extracted the usage limits banners/modal into a reusable component,
LimitNotifications
.I also added transitions to the Button common component - opacity, background color, and text color. I was tempted to do
transition: all 0.2s
, but that might be a bit too far :)