Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make language selector being available in all templates #4609

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Aug 31, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Notes

I simply moved the existing <form> to upper scope, so it is being rendered in all the pages.

Related issues

Part of #3804

@noliveleger
Copy link
Contributor

@magicznyleszek, does the inheritance of base.html make it appear in password reset template too?

@magicznyleszek
Copy link
Member Author

magicznyleszek commented Aug 31, 2023

@magicznyleszek, does the inheritance of base.html make it appear in password reset template too?

Yes, now it will appear everywhere. I assumed we want the option to change the language to be everpresent

…ub.com:kobotoolbox/kpi into 3804-language-selector-in-all-django-templates
@JacquelineMorrissette JacquelineMorrissette merged commit 26ae72b into feature/password-complexity Sep 1, 2023
2 of 4 checks passed
@JacquelineMorrissette JacquelineMorrissette deleted the 3804-language-selector-in-all-django-templates branch September 1, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants