Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to PR template #4617

Merged
merged 3 commits into from Sep 7, 2023
Merged

Add notes to PR template #4617

merged 3 commits into from Sep 7, 2023

Conversation

magicznyleszek
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Following up on the Front end technical call, I'm adding the "Notes" section to PR template with a short description.

@magicznyleszek magicznyleszek marked this pull request as ready for review September 6, 2023 09:37
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added more details and changed placeholders from HTML comments to regular text. I've found that people would simply leave those comments in place instead of writing what they were supposed to write.

@jnm jnm merged commit a7bbb1b into main Sep 7, 2023
3 checks passed
@jnm jnm deleted the pr-template-add-notes branch September 7, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants