Fix wrong language (i.e. English) being picked instead of detected language in language selector #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
noliveleger
changed the title
JacquelineMorrissette
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always save detected language to Django language cookie when it does not exist already to avoid falling back on English
Notes
Overload Django
LocaleMiddlewareto use the detected language by the middleware to set the cookie language when it is not present. It lets the front end load the correct value and set it when rendering the language dropdown menu.Moreover, it will update
extra_details.last_ui_languagewith correct value to get more accurate statistics.Related issues
Fixes #2313