Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve TextBox component #4638

Merged
merged 5 commits into from Sep 19, 2023

Conversation

magicznyleszek
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Add sizing option to TextBox component.

Notes

Things changed here:

  • Added sizes (similar to Button component) and updated story file
  • Added renderFocused option (needed on feature/analysis branch)
  • Changed what number type allows to by typed inside input (we need to be more strict given how unevenly browsers do it)
    • Because of that I had to switch from onChange to onInput callback (hack to fix a bug)
  • Updated the package we use to render <textarea> element to a better one

Related issues

Part of #3914

@magicznyleszek magicznyleszek marked this pull request as ready for review September 14, 2023 15:22
@magicznyleszek magicznyleszek merged commit 8748976 into beta Sep 19, 2023
4 checks passed
@magicznyleszek magicznyleszek deleted the further-improve-textbox-componen branch September 19, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants