Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that SOCIALACCOUNT_PROVIDERS don't use kobo as ID #4653

Merged
merged 1 commit into from Sep 27, 2023

Conversation

JacquelineMorrissette
Copy link
Contributor

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Notes

Using kobo as the social app provider ID causes a conflicting view named kobo-login to be created which causes issues with translation, account login and SSO.
xref: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/Language.20selector.20redirects.20to.20SSO.20Login/near/275179

@JacquelineMorrissette JacquelineMorrissette changed the base branch from beta to release/2.023.37 September 27, 2023 14:46
@noliveleger noliveleger merged commit 4a4ea5f into release/2.023.37 Sep 27, 2023
4 checks passed
@noliveleger noliveleger deleted the add-social-account-check branch September 27, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back end bug Things broken and not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants