Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage limits release fixes #4655

Merged
merged 6 commits into from Sep 22, 2023
Merged

Usage limits release fixes #4655

merged 6 commits into from Sep 22, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Sep 22, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixes a bug where users on the Professional plan were showing usage limits from the Legacy plan.

Notes

  1. Refactors getAccountLimits() so FREE_TIER_THRESHOLDS only applies to users without a plan
  2. Fixes FREE_TIER_THRESHOLDS not being applied to eligible users (see here)
  3. Changes response.results[0]?.plan?.product to response.results[0]?.items[0]?.price?.product in onFetchSubscriptionInfoDone()
  4. Removes stopgap that prevents warnings/modals from showing
  5. Prevent usage banners/modals displaying when they shouldn't by refactoring useExceedingLimits to use getAccountLimits()

@LMNTL LMNTL marked this pull request as ready for review September 22, 2023 19:12
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jnm jnm merged commit a85c5e4 into release/2.023.37 Sep 22, 2023
4 checks passed
@jnm jnm deleted the usage-limits-release-fixes branch September 22, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants