Bump tsconfig target from ES2016 to ES2017 #4669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Change TypeScript compilation target from ES2016 to ES2017.
Notes
This is intended to make TypeScript recognize
Object.entries()
andObject.values()
. See kpi#4660 for an example of hacking the issue (usingas keyof {Type}
). ES2017 is at ~93% use in the wild based on caniuse.com stats, which satisfies our availability requirements.This should (馃檹馃徑) be fully forward compatible. TypeScript doesn't complain at compile time and I haven't been able to make it spit any new errors at me from the SPA. But please do give it some testing.