Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tsconfig target from ES2016 to ES2017 #4669

Merged
merged 1 commit into from Oct 5, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Sep 28, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Change TypeScript compilation target from ES2016 to ES2017.

Notes

This is intended to make TypeScript recognize Object.entries() and Object.values(). See kpi#4660 for an example of hacking the issue (using as keyof {Type}). ES2017 is at ~93% use in the wild based on caniuse.com stats, which satisfies our availability requirements.

This should (馃檹馃徑) be fully forward compatible. TypeScript doesn't complain at compile time and I haven't been able to make it spit any new errors at me from the SPA. But please do give it some testing.

@magicznyleszek magicznyleszek merged commit 4bb5efa into beta Oct 5, 2023
4 checks passed
@magicznyleszek magicznyleszek deleted the bump-tsconfig-target-es2016-es2017 branch October 5, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants