Allow GET to /token/ to create a new API token if none exists
#4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if none exists. The old behavior of POST is unchanged for the sake of API stability. Something in releases prior to 2.023.37 was creating these tokens implicitly. It's not happening anymore, meaning that new accounts are left without API tokens, and the front end has never had any facility to send anything other than a GET to the token endpoint. To avoid the hassle of backfilling tokens for accounts that have none, or of rewriting the front end to send POST whenever GET returns a 404, this change simply allows a GET request to create a token implicitly if none exists.
noliveleger
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior of POST is unchanged for the sake of API stability.
Something in releases prior to 2.023.37 was creating these tokens implicitly. It's not happening anymore, meaning that new accounts are left without API tokens, and the front end has never had any facility to send anything other than a GET to the token endpoint. To avoid the hassle of backfilling tokens for accounts that have none, or of rewriting the front end to send POST whenever GET returns a 404, this change simply allows a GET request to create a token implicitly if none exists.