Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password strength translations fix and templates cleanup #4678

Merged
merged 6 commits into from Oct 10, 2023

Conversation

magicznyleszek
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixes missing translations in the Password Strength UI displayed in account registration form. Also cleans up some code.

Notes

Things changed here:

  • Fixed the Password Strength component is not using translations #4670 bug by adding that missing line: <script src="{% url 'javascript-catalog' %}"></script>
  • Updated the version of normalize.css we use, and now it's coming from npm
  • Did a huge cleanup of our base Django templates:
    • base_simple.html is now the basest of the base templates, i.e. all templates originate from it. This change removes a lot of duplication
    • Fixed indentation
    • Removed that ancient IE8 message

These changes seem relatively straightforward, but since it touches literally every page we have, I would appreciate a bit more clicking around than usual 🙇

Related issues

Fixes #4670

@JacquelineMorrissette JacquelineMorrissette merged commit d7e803c into beta Oct 10, 2023
4 checks passed
@JacquelineMorrissette JacquelineMorrissette deleted the 4670-password-strength-translations-fix branch October 10, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Strength component is not using translations
2 participants