Fix 500 error when loading projects list with PostgreSQL 13 and older #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
added
API
noliveleger
force-pushed
the
fix-array-position-postgres
branch
from
02975be
to
429feeb
Compare
bufke
requested changes
Oct 17, 2023
kpi/utils/django_orm_helper.py
Outdated
|
|
||
| function = 'array_position' | ||
| template = '%(function)s(ARRAY%(order_list)s, %(expressions)s)' | ||
| arity = 1 | ||
|
|
||
| def __init__(self, expression: str, order_list: list, **extra): | ||
| def __init__(self, expression: str, order_list: list, array_type: str, **extra): |
There was a problem hiding this comment.
array_type: str is a required argument. It's allowed to be Literal['varchar'] to get the desired varchar behavior else it will use the implicit cast. Thus to use implicit cast, it must be called with array_type='unicorns' to function as None isn't accepted.
How about making the type Optional[literal['varchar']] = None
If we're going to place the type hint, we should as well make the type useful. Then it can be omitted to use implicit cast and mypy would error if set to unicorns, which is silly.
bufke
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the default projects sorting (i.e.
deployed,draft,archive) work with older versions of PostgreSQL.Notes
OrderRandomORM utility has been renamed to a more explicit name:OrderCustomSupersedes #4685