Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coveralls CI action success not required for CI #4723

Merged
merged 5 commits into from Nov 14, 2023
Merged

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Nov 9, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Resolves an issue that caused python CI to fail.

Notes

This PR is used to fix an issue where the Run coveralls for back-end code step would consistently fail on some branches, causing CI to fail.

Internal thread cross-reference

Unlike #4717, this PR temporarily resolves the issue by adding continue-on-error to the step, since a failure generating the coverage report is unrelated to whether the code passes tests, builds, lints, etc. The coverage % badge will still be updated, since the 422 issue appears to be sporadic and hasn't affected beta or main yet - the main difference will be that some PRs don't submit a coverage report.

@LMNTL LMNTL mentioned this pull request Nov 9, 2023
7 tasks
@LMNTL LMNTL changed the title Don't run coveralls CI action for PRs Don't run coveralls CI action Nov 9, 2023
@LMNTL LMNTL changed the title Don't run coveralls CI action Make coveralls CI action success not required for CI Nov 9, 2023
@LMNTL LMNTL marked this pull request as ready for review November 9, 2023 20:57
@LMNTL
Copy link
Contributor Author

LMNTL commented Nov 10, 2023

Note: CI is failing due to an unrelated CI error with translations. See successful run with latest code here.

@jnm jnm changed the base branch from beta to main November 14, 2023 17:36
@jnm jnm merged commit f5692ce into main Nov 14, 2023
3 checks passed
@jnm jnm deleted the comment-coveralls branch November 14, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants