New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable editing for media type questions with uploads #4725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does the job well! I just have a couple style/accessibility concerns to address before it gets merged.
onClick={this.selectQuestion.bind(this, question)} | ||
disabled={this.disableEdit(question.type)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's preferable to avoid using the disabled
attribute on buttons, since it hides information from screen readers and removes the button from the tab order. (The first part of this article outlines a bit of the dilemma.) You can check out this PR for an example with the <Button>
component.
I think you'd only need to take two steps to make that change:
- Use
aria-disabled
instead ofdisabled
- In the
onClick
handler function (selectQuestion
), don't do anything ifthis.disableEdit
istrue
See this internal thread for additional details.
Checklist
Description
This feature restricts editing for questions supporting uploads within the bulk-edit modal.
Notes
Added the
disableEdit
function which determines if the Edit text button is disabled (and if so, the color changed as well) based on thequestion.type
.